Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct locale automatically #590

Merged
merged 21 commits into from
Dec 4, 2024
Merged

Set the correct locale automatically #590

merged 21 commits into from
Dec 4, 2024

Conversation

deemp
Copy link
Member

@deemp deemp commented Nov 29, 2024 •
edited
Loading

Changes:

  • Used the code-page library for setting the code page on Windows instead of explicitly calling chcp 65001.
  • Improved the exceptions logic so that error messages are first displayed with correct locale enabled, then the program exits.
  • Unified parsing error messages.

@deemp deemp linked an issue Nov 29, 2024 that may be closed by this pull request
the output is not escaped on error #572
Closed
@deemp deemp force-pushed the 572-the-output-is-not-escaped-on-error branch from 5c96743 to 87e1e9c Compare December 3, 2024 19:13
@deemp deemp removed a link to an issue Dec 3, 2024
the output is not escaped on error #572
Closed
@deemp deemp mentioned this pull request Dec 3, 2024
Closed
deemp added 17 commits December 3, 2024 22:49
@deemp
fix(eo-phi-normalizer): don't escape Unicode in errors
406aa8e
@deemp
refactor(eo-phi-normalizer): use a single list of strings
45836bf
@deemp
fix(eo-phi-normalizer): remove pragmas
8131c1c
@deemp
refactor(eo-phi-normalizer): format
7b92de4
@deemp
fix(ci): let check formatting in Setup.hs
0fae402
@deemp
fix(pre-commit): let check formatting in Setup.hs
20d64a0
@deemp
refactor(eo-phi-normalizer): use throwIO instead of throw
fba4c22
@deemp
fix(eo-phi-normalizer): display errors with a correct locale set
8cb4d08
@deemp
refactor(eo-phi-normalizer): fix formatting
aeda68a
@deemp
Merge remote-tracking branch 'origin' into 572-the-output-is-not-esca…
ecbab8e 
…ped-on-error
@deemp
fix(eo-phi-normalizer): use throwIO instead of throw
6fffd52
@deemp
fix(eo-phi-normalizer): apply hlint suggestions
f7522c9
@deemp
refactor(eo-phi-normalizer): move withCorrectLocale to the library
30b6b47
@deemp
feat(eo-phi-normalizer): use withCorrectLocale in tests
6dbd8e7
@deemp
try(ci): don't set codepage on Windows
0c01ef2
@deemp
fix(eo-phi-normalizer): formatting
63d9b8d
@deemp
fix(eo-phi-normalizer): add license
6c09e3c
@deemp deemp changed the title Add simple unicode escaping Set the correct locale automatically Dec 4, 2024
@deemp deemp merged commit ac7276d into master Dec 4, 2024
8 checks passed
deemp added a commit that referenced this pull request Dec 4, 2024
@deemp
Merge pull request #609 from objectionary/572-the-output-is-not-escap…
520b1f0 
…ed-on-error

Small refactoring after #590
@deemp deemp mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deemp